Re: [PATCH v6] i2c: designware: Add support for recovery when GPIO need pinctrl.

[Jarkko Nikula]

On 8/22/23 17:43, Andy Shevchenko wrote:
> On Tue, Aug 22, 2023 at 04:34:37PM +0200, Yann Sionneau wrote:
> > Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C
> > function to GPIO function, the recovery won't work.
> >
> > scl-gpio = <>;
> > sda-gpio = <>;
> >
> > Are not enough for some SoCs to have a working recovery.
> > Some need:
> >
> > scl-gpio = <>;
> > sda-gpio = <>;
> > pinctrl-names = "default", "recovery";
> > pinctrl-0 = <&i2c_pins_hw>;
> > pinctrl-1 = <&i2c_pins_gpio>;
> >
> > The driver was not filling rinfo->pinctrl with the device node
> > pinctrl data which is needed by generic recovery code.
>
> Now looks pretty much good enough (yet the period is not needed in the Subject,
> but it's fine for your newbie submission — no need to resend or make a new
> version). Thank you!
Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>