Re: [PATCH v5 3/3] mmc: atmel-mci: Move card detect gpio polarity quirk to gpiolib

[Balamanikandan.Gunasundar]

On 24/08/23 2:03 pm, Linus Walleij wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Aug 24, 2023 at 8:39 AM <Balamanikandan.Gunasundar@xxxxxxxxxxxxx> wrote:
> 
>>>> +#if IS_ENABLED(CONFIG_MMC_ATMELMCI)
>>>> +       if (of_device_is_compatible(np->parent, "atmel,hsmci") &&
>>
>> The only difference above is "np->parent" while the existing code uses
>> "np". This is because the compatible string is defined in the parent
>> node here while the others have it in the same node.
> 
> Aha. What about this right before the for-loop
> then:
> 
> /* The Atmel MSMCI has the property in a child node of the device */
> if (IS_ENABLED(CONFIG_MMC_ATMELMCI) &&
> of_device_is_compatible(np->parent, "atmel,hsmci"))
>    np = parent->np;
> 

This looks good! I will send a v6.

Thanks,
Balamanikandan

> Yours,
> Linus Walleij