Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

[Hamza Mahfooz]

On 8/24/23 08:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
> > On Thu, 24 Aug 2023, Lee Jones <lee@xxxxxxxxxx> wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@xxxxxxxxxx/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them.  Maybe the maintainers can find a way to test
> new patches on merge?

I guess on that note, do you know if there is a way to run
`scripts/kernel-doc` on patches instead of whole files? That would make
much easier to block new kernel-doc issues from appearing.

> > Most people don't use W=1 because it's too noisy, so it's a bit of a
> > catch-22.
> >
> > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> > Makefile. For CI/developer use we also enable kernel-doc warnings by
> > default.
> >
> > Should we start enabling some of those warning flags in drm/Makefile to
> > to keep the entire subsystem warning free?
>
> That would we awesome!  We'd just need buy-in.
--
Hamza