Re: [PATCH v3] scsi: sli4: Remove code duplication

From: Martin K. Petersen
Date: Thu Aug 24 2023 - 21:14:42 EST


On Thu, 17 Aug 2023 17:13:01 +0530, coolrrsh@xxxxxxxxx wrote:

> In the function sli_xmit_bls_rsp64_wqe, the 'if' and 'else' conditions
> evaluates the same expression and gives same output. Also, params->s_id
> shall not be equal to U32_MAX. Therefore removing the unused code.
>
> This fixes coccinelle warning such as:
> drivers/scsi/elx/libefc_sli/sli4.c:2320:2-4: WARNING: possible
> condition with no effect (if == else)
>
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: sli4: Remove code duplication
https://git.kernel.org/mkp/scsi/c/2d6f70fe175e

--
Martin K. Petersen Oracle Linux Engineering