Re: [PATCH v6 5/7] perf test: Update base-record & system-wide-dummy attr expected values for test-record-C0

[Yang Jihong]

Hello,

On 2023/8/25 13:22, Ian Rogers wrote:
> On Sun, Aug 20, 2023 at 6:30 PM Yang Jihong <yangjihong1@xxxxxxxxxx> wrote:
> > 1. Because a dummy sideband event is added to the sampling of specified
> >     CPUs. When evlist contains evsel of different sample_type,
> >     evlist__config() will change the default PERF_SAMPLE_ID bit to
> >     PERF_SAMPLE_IDENTIFICATION bit.
> >     The attr sample_type expected value of base-record and system-wide-dummy
> >     in test-record-C0 needs to be updated.
> >
> > 2. The perf record uses evlist__add_aux_dummy() instead of
> >     evlist__add_dummy() to add a dummy event.
> >     The expected value of system-wide-dummy attr needs to be updated.
> >
> > The perf test result is as follows:
> >
> >    # ./perf test list  2>&1 | grep 'Setup struct perf_event_attr'
> >     17: Setup struct perf_event_attr
> >    # ./perf test 17
> >     17: Setup struct perf_event_attr                                    : Ok
>
> Will the kernel test robot complain about the previous patches
> breaking this test? It may be best to update the test while changing
> the behavior in those patches.
Okay, it'll be modified in the next version.

Thanks,
Yang