Re: [PATCH v1] drivers: edac: Drop unnecessary error check for debugfs_create_dir

[Michal Simek]

On 8/15/23 22:38, Atul Kumar Pant wrote:
> This patch removes the error checking for debugfs_create_dir.

Avoid using "This patch".

> Even if we get an error from this function, other debugfs APIs will
> handle the error value and doesn't crash in that case. Hence caller can
> safely ignore the errors that occur during the creation of debugfs nodes.

First of all which issue do you have? Did you see that folder is not created?

I am not quite sure if this is the right behavior.
In the code there is
135         if (!parent)
136                 parent = edac_debugfs;

It means you are right that if creating ocm folder can fail and properties will 
be still created under edac_debugfs but is this the right behavior?

altera_edac/armada_xp_edac/i10nm/i5100/igen6/others are checking return value 
that's why I can't see any reason to remove this checking from one driver.

If you want to fix all please send patch for all but I don't think it will 
improve situation and it will just hide different issue if creating folder fails.
And debugfs will be disabled in production system anyway.

Thanks,
Michal