Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype()

[David Hildenbrand]

On 25.08.23 09:36, Vern Hao wrote:
> 在 2023/8/25 15:34, David Hildenbrand 写道:
> > On 25.08.23 09:31, Vern Hao wrote:
> > > 在 2023/8/25 15:12, David Hildenbrand 写道:
> > > > On 25.08.23 06:08, Vern Hao wrote:
> > > > > From: Vern Hao <vernhao@xxxxxxxxxxx>
> > > > >
> > > > > In skip_cma(), we can use folio_migratetype() to replace
> > > > > get_pageblock_migratetype().
> > > > >
> > > > > Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available")
> > > >
> > > > Why did you think "Fixes" was a good idea?
> > > The skip_cma() contains the folio argument, and the folio_migratetype()
> > > is already implemented in the kernel, so I think it's fine to keep it
> > > consistent.
> >
> > If this doesn't actually *fix a bug*, then please don't add fixes and
> > confuse people looking for actual bugfixes.
> >
> > See Documentation/process/submitting-patches.rst
> OK, my bad, i will remove it, thanks.

No need to resend. Andrew can drop that tag when applying.

--
Cheers,

David / dhildenb