Re: [PATCH 1/2] ata: pata_ep93xx: fix error return code in probe

[Damien Le Moal]

On 8/25/23 17:05, Nikita Shubin wrote:
> Hi Damien!
> 
> On Thu, 2023-08-24 at 08:07 +0900, Damien Le Moal wrote:
>> On 8/23/23 18:47, Nikita Shubin via B4 Relay wrote:
>>> From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
>>>
>>> Return -ENOMEM from ep93xx_pata_probe() if devm_kzalloc() or
>>> ata_host_alloc() fails.
>>>
>>> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
>>
>> Doesn't this need a Fixes tag and Cc: stable ?
>>
>> This is not really a bug fix, but might as well be complete with the
>> fix :)
> 
> Well... This would be fix for:
> 
> ```
> commit 2fff27512600f9ad91335577e485a8552edb0abf
> Author: Rafal Prylowski <prylowski@xxxxxxxxxxx>
> Date:   Thu Apr 12 14:13:16 2012 +0200
> ```
> 
> v3.4-rc6-6-g2fff27512600
> 
> Are you sure we wanna tag so solid and time proven commit as Fixes: :)
> ?

Yeah, this is fine without the fixes tag. As I said, not exactly a bug fix but
rather an improvement :)

-- 
Damien Le Moal
Western Digital Research