Re: [PATCH v5 10/10] media: v4l2: Add mem2mem helpers for DELETE_BUFS ioctl

[Benjamin Gaignard]

Le 25/08/2023 à 12:29, kernel test robot a écrit :
> Hi Benjamin,

Damned I have forgot this configuration flag when rebasing my code after 
holidays...

It will be fixed for v6 but I will wait for more comments before send it.

Regards,

Benjamin

> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on next-20230824]
> [also build test ERROR on v6.5-rc7]
> [cannot apply to linus/master v6.5-rc7 v6.5-rc6 v6.5-rc5]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/media-videobuf2-Rework-offset-cookie-encoding-pattern/20230824-172416
> base:   next-20230824
> patch link:    https://lore.kernel.org/r/20230824092133.39510-11-benjamin.gaignard%40collabora.com
> patch subject: [PATCH v5 10/10] media: v4l2: Add mem2mem helpers for DELETE_BUFS ioctl
> config: alpha-randconfig-r005-20230825 (https://download.01.org/0day-ci/archive/20230825/202308251828.fSyIXACx-lkp@xxxxxxxxx/config)
> compiler: alpha-linux-gcc (GCC) 13.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251828.fSyIXACx-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308251828.fSyIXACx-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
> > > drivers/media/test-drivers/vim2m.c:963:10: error: 'const struct v4l2_ioctl_ops' has no member named 'vidioc_delete_buf'; did you mean 'vidioc_delete_bufs'?
>       963 |         .vidioc_delete_buf      = v4l2_m2m_ioctl_delete_buf,
>           |          ^~~~~~~~~~~~~~~~~
>           |          vidioc_delete_bufs
> > > drivers/media/test-drivers/vim2m.c:963:35: error: 'v4l2_m2m_ioctl_delete_buf' undeclared here (not in a function); did you mean 'v4l2_m2m_ioctl_delete_bufs'?
>       963 |         .vidioc_delete_buf      = v4l2_m2m_ioctl_delete_buf,
>           |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~
>           |                                   v4l2_m2m_ioctl_delete_bufs
>
>
> vim +963 drivers/media/test-drivers/vim2m.c
>
>     942	
>     943	static const struct v4l2_ioctl_ops vim2m_ioctl_ops = {
>     944		.vidioc_querycap	= vidioc_querycap,
>     945	
>     946		.vidioc_enum_fmt_vid_cap = vidioc_enum_fmt_vid_cap,
>     947		.vidioc_enum_framesizes = vidioc_enum_framesizes,
>     948		.vidioc_g_fmt_vid_cap	= vidioc_g_fmt_vid_cap,
>     949		.vidioc_try_fmt_vid_cap	= vidioc_try_fmt_vid_cap,
>     950		.vidioc_s_fmt_vid_cap	= vidioc_s_fmt_vid_cap,
>     951	
>     952		.vidioc_enum_fmt_vid_out = vidioc_enum_fmt_vid_out,
>     953		.vidioc_g_fmt_vid_out	= vidioc_g_fmt_vid_out,
>     954		.vidioc_try_fmt_vid_out	= vidioc_try_fmt_vid_out,
>     955		.vidioc_s_fmt_vid_out	= vidioc_s_fmt_vid_out,
>     956	
>     957		.vidioc_reqbufs		= v4l2_m2m_ioctl_reqbufs,
>     958		.vidioc_querybuf	= v4l2_m2m_ioctl_querybuf,
>     959		.vidioc_qbuf		= v4l2_m2m_ioctl_qbuf,
>     960		.vidioc_dqbuf		= v4l2_m2m_ioctl_dqbuf,
>     961		.vidioc_prepare_buf	= v4l2_m2m_ioctl_prepare_buf,
>     962		.vidioc_create_bufs	= v4l2_m2m_ioctl_create_bufs,
>   > 963		.vidioc_delete_buf	= v4l2_m2m_ioctl_delete_buf,
>     964		.vidioc_expbuf		= v4l2_m2m_ioctl_expbuf,
>     965	
>     966		.vidioc_streamon	= v4l2_m2m_ioctl_streamon,
>     967		.vidioc_streamoff	= v4l2_m2m_ioctl_streamoff,
>     968	
>     969		.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
>     970		.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
>     971	};
>     972