Re: [PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code

From: Bart Van Assche
Date: Fri Aug 25 2023 - 12:47:12 EST


On 8/25/23 07:26, Daniel Wagner wrote:
On Fri, Aug 25, 2023 at 06:45:25AM -0700, Bart Van Assche wrote:
I don't like the "new style". What is so hard about typing "$@" to pass all function
arguments to _nvmet_target_setup()? Leaving out "$@" makes it much harder than
necessary to figure out the intent of the code author - not passing any arguments
or passing all caller arguments implicitly.

Because "$@" is just not correct.

Why not?

Thanks,

Bart.