Re: [PATCH v2 1/2] iommu/iova: Make the rcache depot scale better
From: Jerry Snitselaar
Date: Fri Aug 25 2023 - 12:56:53 EST
On Mon, Aug 21, 2023 at 07:22:51PM +0100, Robin Murphy wrote:
> The algorithm in the original paper specifies the storage of full
> magazines in the depot as an unbounded list rather than a fixed-size
> array. It turns out to be pretty straightforward to do this in our
> implementation with no significant loss of efficiency. This allows
> the depot to scale up to the working set sizes of larger systems,
> while also potentially saving some memory on smaller ones too.
>
> Since this involves touching struct iova_magazine with the requisite
> care, we may as well reinforce the comment with a proper assertion too.
>
> Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>
> ---
Reviewed-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>