Re: [PATCH 1/3] dt-bindings: clock: Add Qualcomm SM6115 LPASS clock controller

[Konrad Dybcio]

On 26.08.2023 11:28, Krzysztof Kozlowski wrote:
> On 25/08/2023 20:13, Konrad Dybcio wrote:
>> SM6115 (and its derivatives or similar SoCs) have a LPASS clock
>> controller block which provides audio-related resets.
>>
>> Add bindings for it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>> ---
>>  .../bindings/clock/qcom,sm6115-lpasscc.yaml        | 53 ++++++++++++++++++++++
>>  include/dt-bindings/clock/qcom,sm6115-lpasscc.h    | 15 ++++++
>>  2 files changed, 68 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml
>> new file mode 100644
>> index 000000000000..58ee84aed073
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml
>> @@ -0,0 +1,53 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,sm6115-lpasscc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm LPASS Core & Audio Clock Controller on SM6115
> 
> Everything here looks the same as sc8280xp, so this could be just added
> there as enum. The overall LPASS block version is different, but the
> resets/clock controller look similar, doesn't it?
I think the 6115 cc block is a bit different, 8280 has more swr
hosts. Maybe Srini would know more.

[...]

> Also second example is not really needed. The difference is only in the
> compatible.
Ack

Konrad