Re: [PATCH v3 11/15] media: qcom: camss: Functionally decompose CSIPHY clock lookups

From: Bryan O'Donoghue
Date: Sat Aug 26 2023 - 08:15:37 EST


On 26/08/2023 13:11, Konrad Dybcio wrote:
adding something like csiphy_timer_clks and cisphy_clks and stuff
would make this string comparison mess unnecessary
I don't understand your comment.

Having a litany of static comparisons is definitely inferior to a generic helper function.
portray this

struct camss_whatever_it_was_called {
struct clk_bulk_data *csiphy_clks;
struct clk_bulk_data *csiphy_timer_clks;
[...]
}

and then

clk_bulk_prepare_enable(csiphy_clks)

Ah would be grateful if you had just said "hey could you try using clk_bulk_prepare_enable()"

But, OK.

Thanks !

---
bod