Re: [PATCH 1/8] kbuild: do not run depmod for 'make modules_sign'

[Masahiro Yamada]

On Fri, Aug 25, 2023 at 2:55 PM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
>
> On Wed 23 Aug 2023 20:50:41 GMT, Masahiro Yamada wrote:
> > Commit 961ab4a3cd66 ("kbuild: merge scripts/Makefile.modsign to
> > scripts/Makefile.modinst") started to run depmod at the end of
> > 'make modules_sign'.
> >
> > Move the depmod rule to scripts/Makefile.modinst and run it only when
> > $(modules_sign_only) is empty.
>
> Moving the depmod rule is in patch 3/8, first half of the sentence
> seems to be left over?


Theoretically, 1/8 and 3/8 can be squashed together, but
3/8 is too big to be back-ported.

1/8 was split out for easy back-porting.






> Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>
>
> >
> > Fixes: 961ab4a3cd66 ("kbuild: merge scripts/Makefile.modsign to scripts/Makefile.modinst")
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---
> >
> >  Makefile | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index e0d52539a0f1..7d54a0700c6e 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1877,7 +1877,9 @@ quiet_cmd_depmod = DEPMOD  $(MODLIB)
> >
> >  modules_install:
> >       $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst
> > +ifndef modules_sign_only
> >       $(call cmd,depmod)
> > +endif
> >
> >  else # CONFIG_MODULES
> >
> > --
> > 2.39.2



-- 
Best Regards
Masahiro Yamada