Re: [PATCH v2 00/23] SRSO fixes/cleanups
From: Josh Poimboeuf
Date: Sat Aug 26 2023 - 11:58:26 EST
On Fri, Aug 25, 2023 at 12:38:53PM +0200, Ingo Molnar wrote:
> Thank you, this all looks very nice. I've applied your fixes to
> tip:x86/bugs, with the exception of the two KVM enablement patches.
>
> I've also cherry-picked the apply_returns() fix separately to x86/urgent,
> AFAICS that's the only super-urgent fix we want to push to the final v6.5
> release before the weekend, right? The other fixes look like
> reporting bugs, Kconfig oddities and inefficiencies at worst. Backporters
> may still pick the rest from x86/bugs too - but we are too close to the
> release right now.
As far as I can tell, the apply_returns() fix isn't necessarily urgent,
since after commit 095b8303f383 it went from being an actual bug to just
dead code: the optimization will never take effect now that none of the
rethunk cases use __x86_return_thunk.
On the other hand, if I'm too late sending this, it should be harmless
to merge it into the final v6.5 release.
For the rest of the patches, I think the merge window is fine.
Thanks!
--
Josh