Re: [PATCH v2 1/4] staging: vme_user: fix check alignment of open parenthesis in vme_fake.c
From: Alexon Oliveira
Date: Sat Aug 26 2023 - 17:13:54 EST
On Sat, Aug 26, 2023 at 10:32:33PM +0200, Nam Cao wrote:
> On Sat, Aug 26, 2023 at 05:23:46PM -0300, Alexon Oliveira wrote:
> > On Sat, Aug 26, 2023 at 09:47:16PM +0200, Nam Cao wrote:
> > > On Sat, Aug 26, 2023 at 12:13:05PM -0300, Alexon Oliveira wrote:
> > > > Fixed all CHECK: Alignment should match open parenthesis
> > > > as reported by checkpatch to adhere to the Linux kernel
> > > > coding-style guidelines.
> > > >
> > > > Signed-off-by: Alexon Oliveira <alexondunkan@xxxxxxxxx>
> > >
> > > Patch series should be in a single email thread. But your 4 patches are sent
> > > separately :(
> > >
> >
> > Hmm, ACK, I didn't know that.
> >
> > > Have a look at how your patches are sent on https://lore.kernel.org/linux-staging/
> > > and you will see what I am referring to.
> > >
> >
> > Indeed they were sent as separate emails.
> >
> > > Here's an example of how patch series should be:
> > > https://lore.kernel.org/linux-staging/736c8159-90e9-4575-3c22-5a62515d5c03@xxxxxxxxx/T/#t
> > >
> >
> > Please, if you don't mind me to ask, how's the best way to do that?
> > I've already wrote the cover letter, generated the patches' files again,
> > but I don't know how is the best way to send them as you instructed me
> > using mutt.
>
> You must use the argument "--thread=shallow" while generating patch series
> with git format-patch. Then mutt should correctly send them in a single thread.
>
> The instructions can also be found here:
> https://kernelnewbies.org/FirstKernelPatch
>
Yep, I did like that, however mutt was not sending them as it should,
in a single email thread. I had to send them using "git send-email"
after all. I hope it's correct now. Thank you for your heads up and help
with this.
> Best regards,
> Nam
Best regards.
Alexon Oliveira