Re: [PATCH RESEND v5 1/2] dt-binding: pinctrl: Add NPCM8XX pinctrl and GPIO documentation

[Krzysztof Kozlowski]

On 27/08/2023 11:44, Tomer Maimon wrote:
>>> +      pinctrl: pinctrl@f0800260 {
>>> +        compatible = "nuvoton,npcm845-pinctrl";
>>> +        ranges = <0x0 0x0 0xf0010000 0x8000>;
>>> +        #address-cells = <1>;
>>> +        #size-cells = <1>;
>>> +        nuvoton,sysgcr = <&gcr>;
>>> +
>>> +        gpio0: gpio@f0010000 {
>>
>> unit-address should be 0.
>>
>> Otherwise,
> The unit-address is correct f0010000

Then how does it pass W=1 builds? How unit address can be f0010000 but
reg is 0? Really...

>>
>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>>
>>> +          gpio-controller;
>>> +          #gpio-cells = <2>;
>>> +          reg = <0x0 0xB0>;
> 
> Thanks,
> 
> Tomer

Best regards,
Krzysztof