Re: [PATCH] ethernet: tg3: remove unreachable code

[Simon Horman]

On Sun, Aug 27, 2023 at 10:29:37AM -0700, Michael Chan wrote:
> On Sun, Aug 27, 2023 at 9:51 AM Simon Horman <horms@xxxxxxxxxx> wrote:
> >
> > On Fri, Aug 25, 2023 at 10:04:41PM +0300, Mikhail Kobuk wrote:
> >
> > + Matt Carlson <mcarlson@xxxxxxxxxxxx>
> 
> Matt Carlson is no longer working for Broadcom.

Thanks, got it.

> > > 'tp->irq_max' value is either 1 [L16336] or 5 [L16354], as indicated in
> > > tg3_get_invariants(). Therefore, 'i' can't exceed 4 in tg3_init_one()
> > > that makes (i <= 4) always true. Moreover, 'intmbx' value set at the
> > > last iteration is not used later in it's scope.
> > >
> > > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > >
> > > Fixes: 78f90dcf184b ("tg3: Move napi_add calls below tg3_get_invariants")
> > > Signed-off-by: Mikhail Kobuk <m.kobuk@xxxxxxxxx>
> > > Reviewed-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
> 
> Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>