Re: [PATCH v6 3/3] firmware: Add support for Qualcomm UEFI Secure Application

[Maximilian Luz]

On 8/27/23 23:26, Trilok Soni wrote:
> On 8/27/2023 2:14 PM, Maximilian Luz wrote:
> >   
> > +config QCOM_QSEECOM_UEFISECAPP
> > +	bool "Qualcomm SEE UEFI Secure App client driver"
>
> Why not "tristate"? This driver can be a loadable module, right?

As I understand, modular efivars have still not been fully sorted out in
the kernel. For example, userspace could try and mount efivarfs before
the module has been loaded and by that erroneously determine that the
system doesn't support efivars. So requiring it to be built in for now
is more of a workaround (which has been suggested by Johan Hovold).

There is no technical limitation in this part of the code itself, so
enabling it (and QCOM_QSEECOM for that matter) to be built as module
should be fairly straightforward once that's been sorted out.

> > +	depends on QCOM_QSEECOM
> > +	depends on EFI
> > +	help