RE: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and SERDES0 power domains

[Hongxing Zhu]

> -----Original Message-----
> From: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> Sent: 2023年8月26日 15:34
> To: s.hauer@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; Clark Wang
> <xiaoning.wang@xxxxxxx>; Frank Li <frank.li@xxxxxxx>; Hongxing Zhu
> <hongxing.zhu@xxxxxxx>; shawnguo@xxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and
> SERDES0 power domains
> 
> Hi Richard Zhu
> 
> Thanks!
> 
> How about the dc1 and gpu1 ones?
> 
> On Fri, 2023-08-25 at 15:47 +0800, Richard Zhu wrote:
> > Add missed PCIEA, SATA0 and SERDES0 power domains for HSIO SS.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> 
> Reviewed-by: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> 
Hi Marcel:
Thanks.
I just add the HSIO SS PDs, and verified with my local HSIO support patches.
Since I can't verify the dc1 and gpu1 ones now, so I didn't add them this time.

Best Regards
Richard Zhu

> > ---
> >  drivers/firmware/imx/scu-pd.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/firmware/imx/scu-pd.c
> > b/drivers/firmware/imx/scu-pd.c index 84b673427073..7b8c2689b49c
> > 100644
> > --- a/drivers/firmware/imx/scu-pd.c
> > +++ b/drivers/firmware/imx/scu-pd.c
> > @@ -165,7 +165,10 @@ static const struct imx_sc_pd_range
> > imx8qxp_scu_pd_ranges[] = {
> >         { "gpu0-pid", IMX_SC_R_GPU_0_PID0, 4, true, 0 },
> >
> >         /* HSIO SS */
> > +       { "pcie-a", IMX_SC_R_PCIE_A, 1, false, 0 },
> >         { "pcie-b", IMX_SC_R_PCIE_B, 1, false, 0 },
> > +       { "sata-0", IMX_SC_R_SATA_0, 1, false, 0 },
> > +       { "serdes-0", IMX_SC_R_SERDES_0, 1, false, 0 },
> >         { "serdes-1", IMX_SC_R_SERDES_1, 1, false, 0 },
> >         { "hsio-gpio", IMX_SC_R_HSIO_GPIO, 1, false, 0 },
> 
> Cheers
> 
> Marcel