Re: [PATCH V10 0/4] Add S4 SoC PLLs and Peripheral clock

[Keguang Zhang]

On Mon, Aug 28, 2023 at 1:34 AM Lucas Tanure <tanure@xxxxxxxxx> wrote:
>
> On 22-08-2023 09:27, Yu Tu wrote:
> > 1. Add S4 SoC PLLs and Peripheral clock controller dt-bindings.
> > 2. Add PLLs and Peripheral clock controller driver for S4 SOC.
> >
> >
> > Yu Tu (4):
> >    dt-bindings: clock: document Amlogic S4 SoC PLL clock controller
> >    dt-bindings: clock: document Amlogic S4 SoC peripherals clock
> >      controller
> >    clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver
> >    clk: meson: S4: add support for Amlogic S4 SoC peripheral clock
> >      controller
> >
> > V9 -> V10:
> > 1. Change the relevant S4 CLK patch based on Neil's recently modified
> > patch.
> > 2. Change patch 0003/0004 clocks comment, format and clock flags suggested
> > by Jerome.
> >
> > V8 -> V9: Add patch 0001/0002 dt-bindings tag. Suggested by Krzysztof.
> > V7 -> V8:
> > 1. Change patch 0001/0002 dt-bindings title description, remove "meson".
> > Suggested by Dmitry, Neil.
> > 2. Change patch 0003/0004 clocks comment, format and clock flags suggested by
> > Dmitry, Neil, Jerome.
> >
> > V6 -> V7: Change send patch series as well change format and clock flags
> > suggested by Jerome. Change dt-bindings suggested by Krzysztof.
> > V5 -> V6: Change send patch series, as well change format and clock flags.
> > V4 -> V5: change format and clock flags and adjust the patch series
> > as suggested by Jerome.
> > V3 -> V4: change format and clock flags.
> > V2 -> V3: Use two clock controller.
> > V1 -> V2: Change format as discussed in the email.
> >
> > Link:https://lore.kernel.org/linux-amlogic/20230517070215.28463-1-yu.tu@xxxxxxxxxxx/
> >
> >   .../clock/amlogic,s4-peripherals-clkc.yaml    |   96 +
> >   .../bindings/clock/amlogic,s4-pll-clkc.yaml   |   49 +
> >   drivers/clk/meson/Kconfig                     |   23 +
> >   drivers/clk/meson/Makefile                    |    2 +
> >   drivers/clk/meson/s4-peripherals.c            | 3787 +++++++++++++++++
> >   drivers/clk/meson/s4-peripherals.h            |   57 +
> >   drivers/clk/meson/s4-pll.c                    |  867 ++++
> >   drivers/clk/meson/s4-pll.h                    |   38 +
> >   .../clock/amlogic,s4-peripherals-clkc.h       |  236 +
> >   .../dt-bindings/clock/amlogic,s4-pll-clkc.h   |   43 +
> >   10 files changed, 5198 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-peripherals-clkc.yaml
> >   create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-pll-clkc.yaml
> >   create mode 100644 drivers/clk/meson/s4-peripherals.c
> >   create mode 100644 drivers/clk/meson/s4-peripherals.h
> >   create mode 100644 drivers/clk/meson/s4-pll.c
> >   create mode 100644 drivers/clk/meson/s4-pll.h
> >   create mode 100644 include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h
> >   create mode 100644 include/dt-bindings/clock/amlogic,s4-pll-clkc.h
> >
> >
> > base-commit: bd0f6c57c2b324b6f92ccfe13a8005ff829287b8
> How similar is T7 and S4 regarding the clocks?
> Can S4 clock driver be used by T7 without modifications?
>
Unfortunately not.
But don't worry! The T7 clock driver is coming soon.

> Thanks
> Lucas



-- 
Best regards,

Keguang Zhang