Re: ltp testcases failed due to commit cf3128a7aca

From: Herbert Xu
Date: Sun Aug 27 2023 - 23:07:44 EST


On Mon, Aug 28, 2023 at 02:12:12AM +0000, mengkanglai wrote:
>
> This command eventually use setkey -c to add spdadd entry failed:
> spdadd $src_ipaddr $dst_ipaddr any
>   -P out ipsec $protocol/tunnel/${src_ipaddr}-${dst_ipaddr}/use ;
>
> It returns Invalid argument.
>
> I found this failed due to commit cf3128a7aca(af_key: Reject optional tunnel/BEET mode templates in outbound policies), is latest ltp testcases are not adapted?

Correct. The above specification makes no sense for an outbound
policy as the SA can only be optional for inbound (where IPComp
can be skipped for incompressible plaintext). So change the word
"use" above to "require" and it should work.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt