Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

[Om Prakash Singh]

On 8/25/2023 2:59 AM, Rob Herring wrote:
> On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
> > This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
> > since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> > a more appropriate compatible should be instead as reported at [1].
> >
> > [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@xxxxxxxxxxx/
> >
> > Suggested-by: Om Prakash Singh <quic_omprsing@xxxxxxxxxxx>
> > Suggested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>
> Is it just me or looks like an unrenderable character in these.
Yes there are spacial character before Om and Konrad that should have 
been removed.
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
> >   1 file changed, 5 insertions(+), 19 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> > index 36b0ebd9a44b..bb42f4588b40 100644
> > --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> > @@ -11,13 +11,9 @@ maintainers:
> >   
> >   properties:
> >     compatible:
> > -    oneOf:
> > -      - enum:
> > -          - qcom,prng  # 8916 etc.
> > -          - qcom,prng-ee  # 8996 and later using EE
> > -      - items:
> > -          - const: qcom,sm8450-prng-ee
> > -          - const: qcom,prng-ee
> > +    enum:
> > +      - qcom,prng  # 8916 etc.
> > +      - qcom,prng-ee  # 8996 and later using EE
> >   
> >     reg:
> >       maxItems: 1
> > @@ -32,18 +28,8 @@ properties:
> >   required:
> >     - compatible
> >     - reg
> > -
> > -allOf:
> > -  - if:
> > -      not:
> > -        properties:
> > -          compatible:
> > -            contains:
> > -              const: qcom,sm8450-prng-ee
> > -    then:
> > -      required:
> > -        - clocks
> > -        - clock-names
> > +  - clocks
> > +  - clock-names
> >   
> >   additionalProperties: false
> >   
> >
> > --
> > 2.34.1