Re: [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in read_write.c

[Matthew Wilcox]

On Mon, Aug 28, 2023 at 08:17:52PM +0800, Kemeng Shi wrote:
> on 8/28/2023 8:00 PM, Christoph Hellwig wrote:
> > On Mon, Aug 28, 2023 at 11:50:56PM +0800, Kemeng Shi wrote:
> >> use helpers for calling f_op->{read,write}_iter() in read_write.c
> >>
> > 
> > Why?  We really should just remove the completely pointless wrappers
> > instead.
> > 
> This patch is intended to uniform how we call {read,write}_iter()...
> Would it be good to opencode all call_{read,write}_iter. But I'm not sure
> if these wrappers are really needless...

All three, call_read_iter(), call_write_iter(), call_mmap()
should go.  Miklos dumped them into the tree without any discussion
that I noticed.