Re: [PATCH v3 08/15] media: qcom: camss: Untangle if/else spaghetti in camss

From: Bryan O'Donoghue
Date: Mon Aug 28 2023 - 15:43:57 EST


On 28/08/2023 19:51, Laurent Pinchart wrote:
+ break;
+ default:
return -EINVAL;
This should never happen, as adding support for a new SoC should come
with an update for all the applicable switch/case statements. It's
useful to let the compiler complain if someone forgets to do so, but
with a default case, you will only see the issue at runtime. Could it be
caught at compile time ?


Off the top of my head, I don't think it could be easily caught.

An assert() would catch it early in runtime..

---
bod