Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file

From: Rob Herring
Date: Mon Aug 28 2023 - 17:14:46 EST


On Mon, Aug 28, 2023 at 2:49 PM Shenwei Wang <shenwei.wang@xxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Sent: Monday, August 28, 2023 2:31 PM
> > To: Shenwei Wang <shenwei.wang@xxxxxxx>; Ulf Hansson
> > <ulf.hansson@xxxxxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> > Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> > imx@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > dl-linux-imx <linux-imx@xxxxxxx>
> > Subject: Re: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml
> > > The fixed-regulator is a virtual regulator driver that uses the GPIO pin.
> >
> > We do not talk about drivers but bindings and DTS. Why do you bring again
> > drivers, all the time?
> >
> > > You claimed this
> > > as a hardware chip.
> >
> > ??? Sorry, this is getting boring. The DTS-snippet is a hardware chip.
> > If it is not, then drop it from your DTS. I insist. Srsly, third time I insist.
> >
> >
> > >
> > > The regulator-pd driver also uses the same GPIO pin.
> >
> > Again, what is with the drivers? Can you stop bringing it to the discussion?
> >
>
> I have to admit you have a real talent for debate.

It takes 2...

You've gotten feedback from multiple people that your proposal is not
going to be accepted. The prior attempt of the same thing had similar
feedback from even more people. Please go re-read the responses until
you understand.

For fixed-regulator, I can tell you very easily what the h/w looks like:

Vfix---|gate|---Vfix-gated
|
GPIO--------|

'gate' here may be a chip or discrete transistor. That's a very common
board level component.

If you want to discuss this any further, describe the h/w in terms of
simplified schematics. Otherwise, there is nothing more to discuss.

Rob