Re: [PATCH 4.14 00/57] 4.14.324-rc1 review

[Daniel Díaz]

Hello!

On 28/08/23 4:12 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.324 release.
> There are 57 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.324-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>      Linux 4.14.324-rc1
[...]
> Nathan Lynch <nathanl@xxxxxxxxxxxxx>
>      powerpc/rtas_flash: allow user copy to flash block cache objects
[...]

We see this build regression on PowerPC with GCC-8 and GCC-12:
-----8<-----
  /builds/linux/arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
  /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:22: error: implicit declaration of function 'kmem_cache_create_usercopy'; did you mean 'kmem_cache_create'? [-Werror=implicit-function-declaration]
    flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
                        kmem_cache_create
  /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:20: error: assignment to 'struct kmem_cache *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
    flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
                      ^
----->8-----

That's on defconfig and cell_defconfig.

Bisection points to "powerpc/rtas_flash: allow user copy to flash block cache objects" (5190538c66e5). Reverting that patch makes the build pass again.

Tuxmake reproducer:

  #pip3 install -U tuxmake
  tuxmake --runtime podman --target-arch powerpc --toolchain gcc-8 --kconfig defconfig
  git revert 5190538c66e5e8e7cdbf694afec8291f421e6bcf
  tuxmake --runtime podman --target-arch powerpc --toolchain gcc-8 --kconfig defconfig

Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx