Re: [PATCH V2 1/7] clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574

[Devi Priya]

On 8/26/2023 2:28 AM, Stephen Boyd wrote:
> Quoting Devi Priya (2023-08-25 02:12:28)
> > diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> > index e4ef645f65d1..1c2a72840cd2 100644
> > --- a/drivers/clk/qcom/clk-alpha-pll.c
> > +++ b/drivers/clk/qcom/clk-alpha-pll.c
> > @@ -228,6 +228,18 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = {
> >                  [PLL_OFF_ALPHA_VAL] = 0x24,
> >                  [PLL_OFF_ALPHA_VAL_U] = 0x28,
> >          },
> > +
>
> Why the extra newline? All other types aren't this way.
Sure, will drop it in V3

Thanks,
Devi Priya
> > +       [CLK_ALPHA_PLL_TYPE_NSS_HUAYRA] =  {
> > +               [PLL_OFF_L_VAL] = 0x04,
> > +               [PLL_OFF_ALPHA_VAL] = 0x08,
> > +               [PLL_OFF_TEST_CTL] = 0x0c,
> > +               [PLL_OFF_TEST_CTL_U] = 0x10,
> > +               [PLL_OFF_USER_CTL] = 0x14,
> > +               [PLL_OFF_CONFIG_CTL] = 0x18,
> > +               [PLL_OFF_CONFIG_CTL_U] = 0x1c,
> > +               [PLL_OFF_STATUS] = 0x20,
> > +       },
> > +