Re: [PATCH 6/7] arm64: dts: qcom: ipq5018: Add tsens node

[Sricharan Ramabadhran]

On 8/29/2023 12:55 AM, Krzysztof Kozlowski wrote:
> On 28/08/2023 21:18, Sricharan Ramabadhran wrote:
> > IPQ5018 has tsens V1.0 IP with 4 sensors.
> > There is no RPM, so tsens has to manually enabled.
> > Adding the tsens and nvmem node.
> >
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq5018.dtsi | 23 +++++++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > index 9f13d2dcdfd5..277b3cfc7f72 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > @@ -93,6 +93,29 @@ soc: soc@0 {
> >   		#size-cells = <1>;
> >   		ranges = <0 0 0 0xffffffff>;
> >   
> > +		qfprom_nvmem: qfprom_nvmem@a0000 {
>
> Nope. Come on, where do you see such node naming. Please do not send
> code from downstream, but work on upstream sources. Open other most
> recent DTS, take a look how it is done and try to do something similar.

 sure, will fix it up.
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
>
> compatible is always the first property. Then reg.

 ok, will fix.

Regards,
 Sricharan