Re: [PATCH next] ASoC: cs42l43: Fix missing error code in cs42l43_codec_probe()

From: Charles Keepax
Date: Tue Aug 29 2023 - 04:53:17 EST


On Tue, Aug 29, 2023 at 12:36:35AM -0700, Harshit Mogalapalli wrote:
> When clk_get_optional() fails, the error handling code does a 'goto
> err_pm' with ret = 0, which is resturning success on a failure path.
>
> Fix this by assigning the PTR_ERR(priv->mclk) to ret variable.
>
> Fixes: fc918cbe874e ("ASoC: cs42l43: Add support for the cs42l43")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> ---

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles