Re: [PATCH 01/11] ARM: dts: exynos: enable polling in Exynos 4210
From: Krzysztof Kozlowski
Date: Tue Aug 29 2023 - 05:29:19 EST
On 29/08/2023 11:18, Mateusz Majewski wrote:
> It seems that thermal in Exynos 4210 is broken without this, as it will
> never decrease cooling after increasing it.
>
> Signed-off-by: Mateusz Majewski <m.majewski2@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/samsung/exynos4210.dtsi | 10 ++++++++--
Please split unrelated patches for different subsystems into separate
patchsets.
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
> index 0e27c3375e2e..aae185b7f91c 100644
> --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
> @@ -391,8 +391,14 @@ &cpu_alert2 {
> };
>
> &cpu_thermal {
> - polling-delay-passive = <0>;
> - polling-delay = <0>;
> + /* Exynos 4210 supports thermal interrupts, but only for the rising threshold.
Linux coding style comments are:
/*
* Foo bar
Best regards,
Krzysztof