Re: [PATCH] ACPI: processor: Move MWAIT quirk out of acpi_processor.c

[Guenter Roeck]

On 8/29/23 06:54, Rafael J. Wysocki wrote:
> On Tue, Aug 29, 2023 at 3:44 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > On Mon, Jul 10, 2023 at 05:03:29PM +0300, Michal Wilczynski wrote:
> > > Commit 2a2a64714d9c ("ACPI: Disable MWAIT via DMI on broken Compal board")
> > > introduced a workaround for MWAIT for a specific x86 system.
> > >
> > > Move the code outside of acpi_processor.c to acpi/x86/ directory for
> > > consistency and rename the functions associated with it, so their names
> > > start with "acpi_proc_quirk_" to make the goal obvious.
> > >
> > > No intentional functional impact.
> >
> > Except for:
> >
> > ia64-linux-ld: drivers/acpi/acpi_processor.o: in function `acpi_early_processor_control_setup':
> > acpi_processor.c:(.init.text+0x712): undefined reference to `acpi_proc_quirk_mwait_check'
> > ia64-linux-ld: drivers/acpi/processor_pdc.o: in function `acpi_early_processor_set_pdc':
> > processor_pdc.c:(.init.text+0x72): undefined reference to `acpi_proc_quirk_mwait_check'
> >
> > which breaks all ia64 builds.
> >
> > Time to retire that architecture yet ? No one but me seems to even
> > build test it.
>
> Including 0-day it seems.  This had been in linux-next for several weeks.

Not sure if 0-day is running on linux-next nowadays. There are other
build failures in there which don't seem to be reported either.

Unfortunately, looking into build failures (and crashes) in linux-next
would be a full-time job. I see those failures, but I just don't have the
time to analyze and report them all.

Guenter