Re: [PATCH V4 3/7] cpufreq: amd-pstate: Enable AMD Pstate Preferred Core Supporting.
From: kernel test robot
Date: Tue Aug 29 2023 - 10:53:05 EST
Hi Meng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master v6.5 next-20230829]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Meng-Li/x86-Drop-CPU_SUP_INTEL-from-SCHED_MC_PRIO-for-the-expansion/20230829-144723
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20230829064340.1136448-4-li.meng%40amd.com
patch subject: [PATCH V4 3/7] cpufreq: amd-pstate: Enable AMD Pstate Preferred Core Supporting.
config: x86_64-randconfig-r005-20230829 (https://download.01.org/0day-ci/archive/20230829/202308292233.XhcXfvSm-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230829/202308292233.XhcXfvSm-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308292233.XhcXfvSm-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/cpufreq/amd-pstate.c:692: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Get the highest performance register value.
vim +692 drivers/cpufreq/amd-pstate.c
690
691 /**
> 692 * Get the highest performance register value.
693 * @cpu: CPU from which to get highest performance.
694 * @highest_perf: Return address.
695 *
696 * Return: 0 for success, -EIO otherwise.
697 */
698 static int amd_pstate_get_highest_perf(int cpu, u64 *highest_perf)
699 {
700 int ret;
701
702 if (boot_cpu_has(X86_FEATURE_CPPC)) {
703 u64 cap1;
704
705 ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1);
706 if (ret)
707 return ret;
708 WRITE_ONCE(*highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
709 } else {
710 ret = cppc_get_highest_perf(cpu, highest_perf);
711 }
712
713 return (ret);
714 }
715
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki