Re: [EXT] Re: [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq platdev driver as module

[Aurelien Jarno]

Hi,

On 2023-08-30 03:09, Zhipeng Wang wrote:
> Hi Aurelien,
> 
> I'm not sure why we need to make cpufreq-dt-platdev autoloading, does it make sense? As I understand it we need to actively modprobe cpufreq-dt-platdev, why not?

This is needed to recover the old behavior, where if a CPU supports
cpufreq-dt, it get loaded automatically. Now users has to modprobe
cpufreq-dt-platdev explicitly to get cpufreq-dt to work. This seems like
a regression to me.

Of course one can explicitly make CPUFREQ_DT_PLATDEV=y, but the default
is to build cpufreq-dt-platdev as module when cpufreq-dt is built as
module.

Regards
Aurelien

> > -----Original Message-----
> > From: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> > Sent: 2023年8月30日 2:01
> > To: Zhipeng Wang <zhipeng.wang_1@xxxxxxx>
> > Cc: rafael@xxxxxxxxxx; viresh.kumar@xxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [EXT] Re: [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq
> > platdev driver as module
> > 
> > Caution: This is an external email. Please take care when clicking links or opening
> > attachments. When in doubt, report the message using the 'Report this email'
> > button
> > 
> > 
> > Hi,
> > 
> > On 2023-05-24 15:34, Zhipeng Wang wrote:
> > > Make the cpufreq platdev driver as tristate so that it can be built as
> > > loadable module.
> > >
> > > Signed-off-by: Zhipeng Wang <zhipeng.wang_1@xxxxxxx>
> > > ---
> > >  drivers/cpufreq/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index
> > > 2c839bd2b051..dda3a78bfd5c 100644
> > > --- a/drivers/cpufreq/Kconfig
> > > +++ b/drivers/cpufreq/Kconfig
> > > @@ -218,7 +218,7 @@ config CPUFREQ_DT
> > >         If in doubt, say N.
> > >
> > >  config CPUFREQ_DT_PLATDEV
> > > -     bool
> > > +     tristate "Generic DT based cpufreq platdev driver"
> > >       help
> > >         This adds a generic DT based cpufreq platdev driver for frequency
> > >         management.  This creates a 'cpufreq-dt' platform device, on
> > > the
> > 
> > It seems that this new module is missing support for autoloading, causing issues
> > with CPUFREQ_DT=m.
> > 
> > Before that change, CPUFREQ_DT_PLATDEV ended up selected as =y. Now,
> > CPUFREQ_DT_PLATDEV ends up selected as =m. As it is not autoloaded, it means
> > that cpufreq-dt is not working anymore unless manually running "modprobe
> > cpufreq-dt-platdev".
> > 
> > Could you therefore please add support for autoloading?
> > 
> > Thanks,
> > Aurelien
> > 
> > --
> > Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> > aurelien@xxxxxxxxxxx
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Faurel32.
> > net%2F&data=05%7C01%7Czhipeng.wang_1%40nxp.com%7C84e6deca09fb4
> > e86857608dba8b9df5f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> > %7C638289288492430681%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%
> > 7C%7C&sdata=02iXE8HQXHNXRiA7SMtl%2B5ldGiVDF%2F7GtO%2F0DtAP0EQ
> > %3D&reserved=0

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@xxxxxxxxxxx                     http://aurel32.net