Re: [PATCH 4/5] arm64: dts: qcom: ipq5018: Add USB related nodes

[Nitheesh Sekar]

On 8/25/2023 4:08 PM, Krzysztof Kozlowski wrote:
> On 25/08/2023 11:35, Nitheesh Sekar wrote:
> > Add USB phy and controller nodes.
> >
> > Co-developed-by: Amandeep Singh <quic_amansing@xxxxxxxxxxx>
> > Signed-off-by: Amandeep Singh <quic_amansing@xxxxxxxxxxx>
> > Signed-off-by: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq5018.dtsi | 54 +++++++++++++++++++++++++++
> >   1 file changed, 54 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > index 9f13d2dcdfd5..ff477923a823 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > @@ -238,6 +238,60 @@
> >   				status = "disabled";
> >   			};
> >   		};
> > +
> > +		usbphy0: phy@5b000 {
> > +			compatible = "qcom,ipq5018-usb-hsphy";
> > +			reg = <0x0005b000 0x120>;
> > +
> > +			clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>;
> > +
> > +			resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> > +
> > +			#phy-cells = <0>;
> > +
> > +			status = "disabled";
> > +		};
> > +
> > +		usb: usb2@8a00000 {
> usb@
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Sure, will update.

Regards,
Nitheesh