Re: [PATCH -next] scsi: fnic: Remove unused function fnic_scsi_host_start/end_tag()

From: Bart Van Assche
Date: Wed Aug 30 2023 - 16:02:42 EST


On 8/28/23 18:02, Yang Li wrote:
The function fnic_scsi_host_start_tag() and fnic_scsi_host_end_tag()
are not used anywhere, so remove them.

Are you sure? I think the following output shows that these are being
used:

$ git grep -nHEw 'fnic_scsi_host_(start|end)_tag'
drivers/scsi/fnic/fnic_scsi.c:2171: * fnic_scsi_host_start_tag
drivers/scsi/fnic/fnic_scsi.c:2175:fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc)
drivers/scsi/fnic/fnic_scsi.c:2192: * fnic_scsi_host_end_tag
drivers/scsi/fnic/fnic_scsi.c:2193: * frees tag allocated by fnic_scsi_host_start_tag.
drivers/scsi/fnic/fnic_scsi.c:2196:fnic_scsi_host_end_tag(struct fnic *fnic, struct scsi_cmnd *sc)
drivers/scsi/fnic/fnic_scsi.c:2262: tag = fnic_scsi_host_start_tag(fnic, sc);
drivers/scsi/fnic/fnic_scsi.c:2439: fnic_scsi_host_end_tag(fnic, sc);

Bart.