Re: [PATCH v5 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC

[PeterYin]

On 8/31/23 14:20, Krzysztof Kozlowski wrote:
> On 31/08/2023 07:50, Peter Yin wrote:
> > Add linux device tree entry related to
> > Minerva specific devices connected to BMC SoC.
> >
> > Signed-off-by: Peter Yin <peteryin.openbmc@xxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/Makefile                    |   1 +
> >   .../boot/dts/aspeed-bmc-facebook-minerva.dts  | 377 ++++++++++++++++++
> >   2 files changed, 378 insertions(+)
> >   create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 9e1d7bf3cff6..edb0b2105333 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> >   	aspeed-bmc-facebook-wedge400.dtb \
> >   	aspeed-bmc-facebook-yamp.dtb \
> >   	aspeed-bmc-facebook-yosemitev2.dtb \
> > +	aspeed-bmc-facebook-minerva.dtb \
> Third or fourth time: that's not a correct order. This is a nit, but
> since you keep ignoring it, I don't believe any other feedback was
> applied. Why you did not respond to my comments but just ignored them?
Sorry, I don't notice this is different file.
> Best regards,
> Krzysztof