Re: [PATCH] fbdev: Update fbdev source file paths

[Helge Deller]

On 8/31/23 10:51, Daniel Vetter wrote:
> On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neuschäfer wrote:
> > On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote:
> > > Hi
> > >
> > > Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer:
> > > > The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and
> > > > fbcmap.c were moved to drivers/video/fbdev, and subsequently to
> > > > drivers/video/fbdev/core, in the commits listed below.
> > > >
> > > > Reported by kalekale in #kernel (Libera IRC).
> > > >
> > > > Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
> > > > Fixes: 19757fc8432a ("fbdev: move fbdev core files to separate directory")
> > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> > >
> > > IMHO these comments might just be removed.
> >
> > I think it's nice to have some sort of visual separation between groups
> > of functions in fb.h, which these comments provide at the moment.
> > Therefore I'm currently leaning towards my patch as it is, but I'm
> > willing to have my mind changed and do a v2 which just removes the
> > comments.
>
> Just the filename without the full path maybe?

Yes, I'd prefer that as well.

Helge

> That's enough to find the
> right file, and it's also better at highlighting the actual important part
> of the comment since the path is very redundant.
> -Sima
>
> > Thanks
> >
> > > Best regards
> > > Thomas
> > >
> > > > ---
> > > >    include/linux/fb.h | 12 ++++++------
> > > >    1 file changed, 6 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/include/linux/fb.h b/include/linux/fb.h
> > > > index ce7d588edc3e6..3cda5b9f2469b 100644
> > > > --- a/include/linux/fb.h
> > > > +++ b/include/linux/fb.h
> > > > @@ -592,7 +592,7 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
> > > >    	__FB_DEFAULT_SYS_OPS_DRAW, \
> > > >    	__FB_DEFAULT_SYS_OPS_MMAP
> > > >
> > > > -/* drivers/video/fbmem.c */
> > > > +/* drivers/video/fbdev/core/fbmem.c */
> > > >    extern int register_framebuffer(struct fb_info *fb_info);
> > > >    extern void unregister_framebuffer(struct fb_info *fb_info);
> > > >    extern int fb_prepare_logo(struct fb_info *fb_info, int rotate);