Re: [GIT PULL] smb3 client fixes

[Dr. David Alan Gilbert]

* Linus Torvalds (torvalds@xxxxxxxxxxxxxxxxxxxx) wrote:
> On Wed, 30 Aug 2023 at 13:48, Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > - move UCS-2 conversion code to fs/nls and update cifs.ko and jfs.ko to use them
> 
> I've pulled this, but I think the new NLS_UCS2_UTILS config option
> shouldn't be something that is asked about. The filesystems that want
> it already select it, and users shouldn't be asked about a module with
> no use.
> 
> The way to do that is to simply not have a user query string for it,
> ie instead of
> 
>   config NLS_UCS2_UTILS
>           tristate "NLS UCS-2 UTILS"
> 
> it could be (an dI think should be) just
> 
>   config NLS_UCS2_UTILS
>           tristate
> 
> which tells the config system not to ask users about it.
>
> Because users really shouldn't be asked questions that there is no point in.

Agreed.
I'll check it today and send a patch.

Thanks,

Dave

> 
> And then, on a purely visual commentary about your pull request -
> lines like these are just noise:
> 
> >  fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} | 156
> > +++++-------------------------------------
> >  fs/nls/nls_ucs2_utils.h                          | 285
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> and the problem seems to be that you generate the diffstat in a very
> wide terminal (where git tries to be helpful and give you lots of
> detail), and then you cut-and-paste the result.
> 
> If you pipe it to a tool instead (xsel, perhaps), git will limit the
> width of the diffstat to something sane.
> 
> Or, if you really want to use a terminal and cut-and-paste it
> manually, you could try to tell git to use '--stat=72' to limit the
> stat to 72 characters (which is the canonical "width for email", as
> the Lord spake unto us all in rfc822, even if the Lord was confused
> and also mentioned the number 65).
> 
>                          Linus
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/