RE: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()

[Biju Das]

Hi Laurent Pinchart,

> Subject: Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional
> around *_of_get_bridge()
> 
> On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
> > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > and
> > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > drm_bridge.h.
> 
> This will increase the kernel size on non-OF system, to add functions that
> are not used. I don't think the #ifdef here is problematic.

OK agreed. I guess for NON-OF system it will give build error
for function redefinition, if that is the case I would like to
drop this patch.

static inline struct drm_bridge *devm_drm_of_get_bridge()

vs

struct drm_bridge *devm_drm_of_get_bridge()


Cheers,
Biju

> 
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v6:
> >  * New patch.
> > ---
> >  drivers/gpu/drm/bridge/panel.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c
> > b/drivers/gpu/drm/bridge/panel.c index 7f41525f7a6e..9220a1c23697
> > 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -482,7 +482,6 @@ struct drm_connector
> > *drm_panel_bridge_connector(struct drm_bridge *bridge)  }
> > EXPORT_SYMBOL(drm_panel_bridge_connector);
> >
> > -#ifdef CONFIG_OF
> >  /**
> >   * devm_drm_of_get_bridge - Return next bridge in the chain
> >   * @dev: device to tie the bridge lifetime to @@ -550,5 +549,3 @@
> > struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
> >  	return bridge;
> >  }
> >  EXPORT_SYMBOL(drmm_of_get_bridge);
> > -
> > -#endif
> 
> --
> Regards,
> 
> Laurent Pinchart