Re: [PATCH 1/9] dt-bindings: phy: qcom,uniphy: Rename ipq4019 usb PHY to UNIPHY

[Praveenkumar I]

On 8/31/2023 6:04 PM, Dmitry Baryshkov wrote:
> On Thu, 31 Aug 2023 at 15:30, Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> wrote:
> > On 8/31/2023 5:47 PM, Dmitry Baryshkov wrote:
> > > On Thu, 31 Aug 2023 at 14:54, Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> wrote:
> > > > On 8/29/2023 7:49 PM, Dmitry Baryshkov wrote:
> > > > > On Tue, 29 Aug 2023 at 16:59, Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> wrote:
> > > > > > UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to
> > > > > > ipq4019 PHY. Hence renaming this dt-binding to uniphy dt-binding and
> > > > > > can be used for other qualcomm SoCs which are having similar UNIPHY.
> > > > > >
> > > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > > > > > ---
> > > > > >     .../phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml}  | 9 +++++++--
> > > > > >     1 file changed, 7 insertions(+), 2 deletions(-)
> > > > > >     rename Documentation/devicetree/bindings/phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} (78%)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml
> > > > > > similarity index 78%
> > > > > > rename from Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
> > > > > > rename to Documentation/devicetree/bindings/phy/qcom,uniphy.yaml
> > > > > > index 09c614952fea..cbe2cc820009 100644
> > > > > > --- a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml
> > > > > > @@ -1,13 +1,18 @@
> > > > > >     # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > > > >     %YAML 1.2
> > > > > >     ---
> > > > > > -$id: http://devicetree.org/schemas/phy/qcom-usb-ipq4019-phy.yaml#
> > > > > > +$id: http://devicetree.org/schemas/phy/qcom,uniphy.yaml#
> > > > > >     $schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > > >
> > > > > > -title: Qualcom IPQ40xx Dakota HS/SS USB PHY
> > > > > > +title: Qualcomm UNIPHY
> > > > > We know that UNIPHY was a common design / IP block used for APQ8064
> > > > > SATA and MSM8974 DSI and HDMI PHYs. Is this the same design, or was
> > > > > the name reused by the Qualcomm for some other PHYs?
> > > > > Several latest generations have USB QMP PHYs which are called 'uni-phy'.
> > > > This PHY is build on top of QCA Uniphy 22ull. A combo PHY used between
> > > > USB Gen3 / PCIe Gen3 controller.
> > > > It is different from USB QMP PHYs.
> > > So we have now three different items called Qualcomm uniphy. Could you
> > > please add some distinctive name?
> > There is one more target called IPQ5018 which is also having similar USB
> > PHY built on top of
> > Uniphy 28nm LP. That also can leverage this upcoming IPQ5332 USB PHY
> > driver. Considering that,
> > given a common name 'uniphy'.
> Just to verify, do we mean the same thing, when speaking about the
> 28nm LP UNIPHY?
> I was referencing the apq8064 SATA and msm8974 HDMI / DSI PHYs. See [1] and [2].
>
> [1] https://patchwork.freedesktop.org/patch/544131/?series=118210&rev=2
> [2] https://patchwork.freedesktop.org/patch/544125/?series=118210&rev=2
No, this seems different from the PHY used on IPQ5018 / IPQ5332. PHY in 
QualcommIPQ
targets requires minimal SW configuration for the bring up.
> > - Praveenkumar
> > > > - Praveenkumar
> > > > > >     maintainers:
> > > > > >       - Robert Marko <robert.marko@xxxxxxxxxx>
> > > > > > +  - Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > > > > > +
> > > > > > +description:
> > > > > > +  UNIPHY / COMBO PHY supports physical layer functionality for USB and PCIe on
> > > > > > +  Qualcomm chipsets.
> > > > > >
> > > > > >     properties:
> > > > > >       compatible:
> > > > > > --
> > > > > > 2.34.1