Re: [PATCH 4/5] arm64: dts: ti: k3-j721s2-main: Add main domain watchdog entries

[J, KEERTHY]

On 8/31/2023 5:18 PM, Nishanth Menon wrote:
> On 12:56-20230830, Keerthy wrote:
> > Add DT entries for main domain watchdog instances.
> >
> > Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> > ---
> >   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 18 ++++++++++++++++++
> >   1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > index 87841bcc509d..33276d31faa1 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > @@ -1513,4 +1513,22 @@
> >   		reg = <0x0 0x700000 0x0 0x1000>;
> >   		ti,esm-pins = <344>, <345>;
> >   	};
> > +
> > +	watchdog0: watchdog@2200000 {
> > +		compatible = "ti,j7-rti-wdt";
> > +		reg = <0x0 0x2200000 0x0 0x100>;
> > +		clocks = <&k3_clks 286 1>;
> > +		power-domains = <&k3_pds 286 TI_SCI_PD_EXCLUSIVE>;
> > +		assigned-clocks = <&k3_clks 286 1>;
> > +		assigned-clock-parents = <&k3_clks 286 5>;
> > +	};
> > +
> > +	watchdog1: watchdog@2210000 {
> > +		compatible = "ti,j7-rti-wdt";
> > +		reg = <0x0 0x2210000 0x0 0x100>;
> > +		clocks = <&k3_clks 287 1>;
> > +		power-domains = <&k3_pds 287 TI_SCI_PD_EXCLUSIVE>;
> > +		assigned-clocks = <&k3_clks 287 1>;
> > +		assigned-clock-parents = <&k3_clks 287 5>;
> > +	};
>
> Are these all the wdts in main domain - do define and leave the other wdts
> disabled as they are tightly coupled to other processors (and must be
> enabled by the OS running on them), but defining them allows us to reuse
> the definitions in OSes running on R5s (for instance) to reuse the same
> device definitions.

Hello Nishanth,

Okay. I will add all the remaining ones & keep them disabled.

Thanks for the feedback.

Regards,
Keerthy

> >   };
> > --
> > 2.17.1