Re: [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate()

[Michael Büsch]

On Thu, 31 Aug 2023 10:07:33 +0300 (MSK)
Ранд Дееб <deeb.rand@xxxxxxxxxxxx> wrote:

> 1- Yes, I agree that your solution is simpler, and I thought about
> it, but I thought that the one who set the value zero put it for some
> reason, so I did not want to change it.


Yes, I understand your reasoning and I had the same thought initially.
But I looked into the code and I am pretty sure that there is no reason
for the default case returning 0.
In fact, I think returning a 1 as default makes much more sense as the
default value for a factor.

Changing this from 0 to 1 will get my ack.

-- 
Michael Büsch
https://bues.ch/

Attachment: pgpvNvksp7iNu.pgp
Description: OpenPGP digital signature