Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

[Rob Herring]

On Wed, Aug 30, 2023 at 11:13:51PM +0200, Konrad Dybcio wrote:
> The HSPHY is (or at least can be) one of the users of the reference
> voltage generating regulator. Ensure that dependency is described
> properly.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> index 0f200e3f97a9..e895b6c4ee49 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> @@ -53,6 +53,9 @@ properties:
>      items:
>        - description: PHY core reset
>  
> +  refgen-supply:
> +    description: phandle to the REFGEN regulator node

Supply names are local to the device (sink name), but this seems to be 
named based on the supply source. Maybe hard to do if all internal 
stuff. What is this supplying and what's the source if not REFGEN?


> +
>    vdda-pll-supply:
>      description: phandle to the regulator VDD supply node.
>  
> 
> -- 
> 2.42.0
>