Re: [PATCH v1 1/3] perf parse-events: Minor help message improvements

From: Liang, Kan
Date: Thu Aug 31 2023 - 14:33:02 EST



The other thread address the only issue I found when I tested the patch
series on a hybrid machine.
https://lore.kernel.org/lkml/c2affcc9-468f-bf4c-a080-65b31e05a83f@xxxxxxxxxxxxxxx/

The patch series looks good.

Tested-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

Thanks,
Kan

On 2023-08-30 3:07 a.m., Ian Rogers wrote:
> Be more specific and fix a typo.
>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> tools/perf/util/parse-events.y | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 3a9d4e2513b5..4a370c36a0d5 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -342,7 +342,7 @@ PE_NAME opt_pmu_config
> struct parse_events_error *error = parse_state->error;
> char *help;
>
> - if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
> + if (asprintf(&help, "Unable to find PMU or event on a PMU of '%s'", $1) < 0)
> help = NULL;
> parse_events_error__handle(error, @1.first_column,
> strdup("Bad event or PMU"),
> @@ -368,7 +368,7 @@ PE_NAME sep_dc
> struct parse_events_error *error = parse_state->error;
> char *help;
>
> - if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
> + if (asprintf(&help, "Unable to find event on a PMU of '%s'", $1) < 0)
> help = NULL;
> parse_events_error__handle(error, @1.first_column, strdup("Bad event name"), help);
> free($1);