Re: [PATCH v1 0/3] perf list/debug output fixes
From: Arnaldo Carvalho de Melo
Date: Thu Aug 31 2023 - 15:25:26 EST
Em Thu, Aug 31, 2023 at 11:41:51AM -0700, Ian Rogers escreveu:
> On Thu, Aug 31, 2023 at 11:28 AM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
> >
> >
> >
> > On 2023-08-31 3:14 a.m., Ian Rogers wrote:
> > > Fix a long standing parse_events_term cloning bug so that the bad
> > > display of terms can be fixed and the code somewhat more intuitive:
> > > https://lore.kernel.org/lkml/20230830070753.1821629-2-irogers@xxxxxxxxxx/
> > >
> >
> > Tested-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>
> Thanks Kan!
> Ian
Thanks, applied.
- Arnaldo
> > Thanks,
> > Kan
> >
> > > Fix a bug caused by the rename of 'cpu' to 'default_core' in perf list.
> > >
> > > Add more documentation, increase type safety and fix some related bugs
> > > where terms weren't initialized properly.
> > >
> > > Ian Rogers (3):
> > > perf list: Don't print Unit for default_core
> > > perf parse-events: Name the two term enums
> > > perf parse-events: Fix propagation of term's no_value when cloning
> > >
> > > tools/perf/builtin-list.c | 2 +-
> > > tools/perf/util/parse-events.c | 203 +++++++++++++++++++++++----------
> > > tools/perf/util/parse-events.h | 60 +++++++---
> > > tools/perf/util/parse-events.l | 2 +-
> > > tools/perf/util/parse-events.y | 27 +++--
> > > tools/perf/util/pmu.c | 2 +-
> > > 6 files changed, 207 insertions(+), 89 deletions(-)
> > >
--
- Arnaldo