Re: [PATCH v5 13/32] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition

[Wesley Cheng]

Hi Rob,

On 8/31/2023 10:24 AM, Rob Herring wrote:
> On Tue, Aug 29, 2023 at 02:06:38PM -0700, Wesley Cheng wrote:
> > Add a new definition for specifying how many XHCI secondary interrupters
> > can be allocated.  XHCI in general can potentially support up to 1024
> > interrupters, which some uses may want to limit depending on how many
> > users utilize the interrupters.
> >
> > Signed-off-by: Wesley Cheng <quic_wcheng@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/usb/snps,dwc3.yaml          | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index a696f23730d3..596762ef9b9f 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -376,6 +376,19 @@ properties:
> >       items:
> >         enum: [1, 4, 8, 16, 32, 64, 128, 256]
> >   
> > +  snps,num-hc-interrupters:
>
> Why do you still have this when you defined a common property?
>
> If you want to limit it here, just do:
>
> num-hc-interrupters:
>    maximum: 8

Thanks for the review, and apologies for missing your response in the 
previous revision.

Currently, the DWC3 driver creates and populates the XHCI platform 
device properties from the DWC3 host driver.  Properties need to be 
propagated from DWC3 --> XHCI plat, and is currently done this way for
"snps,usb3_lpm_capable"
"snps,usb2-lpm-disable"

XHCI plat can be used for other non-DWC3 implementations as well, which 
would have their own way of creating the XHCI plat platform device. 
This is the reason we'd need to have these two definitions.

Thanks
Wesley Cheng