Re: [PATCH] drm/amd/display: remove useless check in should_enable_fbc()

[Alex Deucher]

Applied.  Thanks!

Alex

On Thu, Aug 31, 2023 at 2:48 PM Harry Wentland <harry.wentland@xxxxxxx> wrote:
>
> On 2023-08-30 10:01, Dembskiy Igor wrote:
> > It does not make sense to compare a pointer to array element with NULL.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable fbc")
> > Signed-off-by: Dembskiy Igor <dii@xxxxxxxxxx>
>
> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > index 6966420dfbac..e87cf54ec658 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > @@ -1992,9 +1992,6 @@ static bool should_enable_fbc(struct dc *dc,
> >
> >                       pipe_ctx = &res_ctx->pipe_ctx[i];
> >
> > -                     if (!pipe_ctx)
> > -                             continue;
> > -
> >                       /* fbc not applicable on underlay pipe */
> >                       if (pipe_ctx->pipe_idx != underlay_idx) {
> >                               *pipe_idx = i;
>