Re: [PATCH v2 3/5] mm: Add structure to keep sva information

[Baolu Lu]

On 2023/9/1 11:36, Zhang, Tina wrote:
> > -----Original Message-----
> > From: Baolu Lu<baolu.lu@xxxxxxxxxxxxxxx>
> > Sent: Thursday, August 31, 2023 10:45 AM
> > To: Zhang, Tina<tina.zhang@xxxxxxxxx>; Jason Gunthorpe<jgg@xxxxxxxx>;
> > Tian, Kevin<kevin.tian@xxxxxxxxx>; Michael Shavit<mshavit@xxxxxxxxxx>
> > Cc:baolu.lu@xxxxxxxxxxxxxxx;iommu@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v2 3/5] mm: Add structure to keep sva information
> >
> > On 2023/8/27 16:43, Tina Zhang wrote:
> > > Introduce iommu_mm_data structure to keep sva information (pasid and
> > > the related sva domains). Add iommu_mm pointer, pointing to an
> > > instance of iommu_mm_data structure, to mm.
> > >
> > > Signed-off-by: Tina Zhang<tina.zhang@xxxxxxxxx>
> > > ---
> > >    include/linux/iommu.h    | 5 +++++
> > >    include/linux/mm_types.h | 2 ++
> > >    2 files changed, 7 insertions(+)
> > Nit:
> >
> > iommu also has a per-device private pointer, it's defined as struct dev_iommu
> > and stored at dev->iommu. Is it valuable to align both?
> I'm not sure if I understand the idea correctly. This struct dev_iommu is used to describe a collection per-device IOMMU data. Is the idea about migrating some bits from this struct dev_iommu to iommu_mm_data structure?

Never mind. I just thought about this when I was reading the patch. This
does not constitute any suggestion.

Best regards,
baolu