Re: [PATCH v6 09/11] ext4: add some kunit stub for mballoc kunit test

From: IBM
Date: Fri Sep 01 2023 - 10:18:24 EST


Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes:

> Multiblocks allocation will read and write block bitmap and group
> descriptor which reside on disk. Add kunit stub to function
> ext4_get_group_desc, ext4_read_block_bitmap_nowait, ext4_wait_block_bitmap
> and ext4_mb_mark_context to avoid real IO to disk.
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
> ---
> fs/ext4/balloc.c | 10 ++++++++++
> fs/ext4/mballoc.c | 4 ++++
> 2 files changed, 14 insertions(+)

The patch looks good to me. Nice work in identifying functions which are
does I/O in mballoc context.

Looks good to me. Feel free to add -

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>

-ritesh